DragonFly kernel List (threaded) for 2007-03
DragonFly BSD
DragonFly kernel List (threaded) for 2007-03
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: first stab at simple mailer


From: "Simon 'corecode' Schubert" <corecode@xxxxxxxxxxxx>
Date: Fri, 23 Mar 2007 12:55:54 +0100

Alexander Shiryaev wrote:
 > comments welcome!  (and contributions as well)
Don't use GOTO.

why not? simple cases of goto tend to be easily understandable, yet doing it without goto often tends to be spaghetti-if()s.


it->sender = sender;
host = strrchr(it->addr, '@');
if ((host != NULL) && (strcmp(host + 1, "localhost") != 0) && (strcmp(host + 1, hostname()) != 0)) {

however, this for sure is nicer. the other code grew a little bit :)


cheers
 simon

--
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \

Attachment: signature.asc
Description: OpenPGP digital signature



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]