DragonFly kernel List (threaded) for 2007-01
Re: [PATCH] Dynamic kernel environment support (kgetenv() and friends), ACPI quirks
:Attached patch adds dynamic kernel enviroment support, adapted from
:FreeBSD; this allows us to actually be able to use ACPI quirks. As such
:I also introduce an ACPI quirk entry for the VMware ACPI-fast24 timer,
:which runs like mad.
:If noone objects, I'll commit tomorrow.
: Thomas E. Spanjaard
It looks good. I found two minor, unimportant cleanup issues.
* sysctl_kenv() (which you have #ifdef notyet'd so the code is not
compiled in yet)... you are missing a spin_unlock. heh. yah yah,
and probably ten other things too.
* kenv_uninit() is holding a spin lock across a kfree(), which is
not legal. Of course, insofar as I can tell, kenv_uninit() will
never run since it is a SYSUNINIT in a mandatry kernel module,
so you could probably remove the whole routine and remove the
In anycase, no objections here! Commit away!