DragonFly BSD
DragonFly kernel List (threaded) for 2005-08
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: Wiki TODO Entry: check usage of setenv()


From: "Simon 'corecode' Schubert" <corecode@xxxxxxxxxxxx>
Date: Wed, 10 Aug 2005 15:39:10 +0200

On 10.08.2005, at 13:35, Gordon Bergling wrote:
on http://wiki.dragonflybsd.org/index.php/SoC are several projects
listed. I have some spare time today and would like to take the setenv part.

cool!


1. What about src/contrib?

usually don't care, except if it is a set[ug]id binary or a daemon etc. At least that's how I see it.


2. is something like
 |  if( setenv(....) != 1 )
 |  {
 |     fprintf(stderr, "Malloc failed!");
 |  }

enough or is there more to do?

that depends on the context. Maybe the env setting isn't ciritical, so a warning might be sufficient. Maybe setting the variable is an absolute must, and a failure demands aborting the execution (i could imagine env(1) would be such a candidate)


cheers
  simon

--
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low $$$ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \

Attachment: PGP.sig
Description: This is a digitally signed message part



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]