DragonFly BSD
DragonFly commits List (threaded) for 2013-07
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: git: kernel: Add PROC_LOCK and PROC_UNLOCK


From: "Sascha Wildner" <saw@xxxxxxxxx>
Date: Mon, 22 Jul 2013 13:21:47 +0200

On Sun, 21 Jul 2013 23:16:02 +0200, Francois Tigeot  
<ftigeot@crater.dragonflybsd.org> wrote:

>
> commit e912b9369a5dd45e860a62d8be988e729df23c32
> Author: François Tigeot <ftigeot@wolfpond.org>
> Date:   Sun Jul 21 21:22:41 2013 +0200
>
>     kernel: Add PROC_LOCK and PROC_UNLOCK
>    Inspired-from: FreeBSD

This leads to some confusion in the kernel build because it redefines  
these names in iscsi and bktr which do not actually grab the token, but  
define them as empty. I think it breaks LINT, too.

Also, it's kind of confusing to give them the same name as FreeBSD, since  
tokens are not hard locks.

My suggestion is that we should explicitly grab the token in whatever code  
that is supposed to use the macros from <sys/proc.h> (I guess it's for  
drm2), instead of hiding it behind unclear names that suggest something  
else.

Sascha



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]