Re: git: x86_64 mptable - maximum lapic id is 64

[Sepherosa Ziehau <sepherosa@xxxxxxxxx>]

On Sun, Jul 29, 2012 at 10:59 PM, Alex Hornung
<alexh@crater.dragonflybsd.org> wrote:
>
> commit c81c1e3460b022d0083fcd243e745318f5c04a17
> Author: Alex Hornung <alex@alexhornung.com>
> Date:   Sun Jul 29 12:00:53 2012 +0000
>
>     x86_64 mptable - maximum lapic id is 64
>
>      * In x86_64, lapic ids with HT can be up to 64, not 32 as in i386.

Hmm, are you using MPTABLE to detect CPU topology?  I suggest avoid
using MPTABLE, if possible.  I didn't have take a look at the SMT
aware scheduling, but I think the CPU topology probably should be
detected using:
http://download.intel.com/products/processor/manual/253668.pdf
section 8.9.2

or something like following article:
http://software.intel.com/en-us/articles/intel-64-architecture-processor-topology-enumeration/

Best Regards,
sephe

>
>     Reported-by: Mihai Carabas, Francois Tigeot
>
> Summary of changes:
>  sys/platform/pc64/x86_64/mptable.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/c81c1e3460b022d0083fcd243e745318f5c04a17
>
>
> --
> DragonFly BSD source repository



-- 
Tomorrow Will Never Die