DragonFly BSD
DragonFly commits List (threaded) for 2011-03
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

git: Don't leave Value32 uinitialized (as it's not completely filled)


From: Sepherosa Ziehau <sephe@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 27 Mar 2011 03:43:41 -0700 (PDT)

commit d2f2ef3a8fdb729f771e0512efa0b61b4b2287d3
Author: Magliano Andrea <masterblaster@tiscali.it>
Date:   Tue Mar 1 08:42:05 2011 +0100

    Don't leave Value32 uinitialized (as it's not completely filled)
    
    OsdHardware.c:AcpiOsReadPort() casts Value to (u_int8_t *) resp.
    (u_int16_t *) when assigning, thus leaving the upper region of Value32
    untouched. If Value32 isn't initialized, random data remains trashing
    the whole value.
    
    Without this every bus_space_read_[12] is virtually screwed up.

Summary of changes:
 sys/contrib/dev/acpica-unix/executer/exregion.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/d2f2ef3a8fdb729f771e0512efa0b61b4b2287d3


-- 
DragonFly BSD source repository



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]