Re: cvs commit: src/sys/netinet ip_flow.c

["Sepherosa Ziehau" <sepherosa@xxxxxxxxx>]

On Tue, Oct 28, 2008 at 3:00 AM, Matthew Dillon
<dillon@apollo.backplane.com> wrote:
> :  Modified files:
> :    sys/netinet          ip_flow.c
> :  Log:
> :  We obviously do not want protocol threads to be block; blocking the current
> :  protocol thread may cause exact same ipflow being installed.
> :
> :  Revision  Changes    Path
> :  1.24      +1 -2      src/sys/netinet/ip_flow.c
> :
> :http://www.dragonflybsd.org/cvsweb/src/sys/netinet/ip_flow.c.diff?r1=1.23&r2=1.24&f=u
>
>    Agree.  I'm not familiar with that code, but I assume that
>    nothing bad will happen if that kmalloc fails?  does ipflow

If one ipflow (e.g. ip1->ip2) allocation failed, later packet from ip1
to ip2 will try to create it again.  Nothing bad will happen.

>    try to detect SYN's and such?

It only takes a look at src/dst ip address and tos.

Best Regards,
sephe

-- 
Live Free or Die