DragonFly commits List (threaded) for 2006-12
DragonFly BSD
DragonFly commits List (threaded) for 2006-12
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/dev/disk/nata ata-all.c


From: "Simon 'corecode' Schubert" <corecode@xxxxxxxxxxxx>
Date: Wed, 13 Dec 2006 23:09:08 +0100

Matthew Dillon wrote:
:tgen 2006/12/13 04:41:36 PST
:
:DragonFly src repository
:
: Modified files:
: sys/dev/disk/nata ata-all.c : Log:
: Explicitly specify null_dtor as our objcache destructor. Fixes a panic when
: we were out of empty magazines.


I'll clean this all up in a moment. It's better for the API to pass NULL
and have null_ctor and null_dtor be static procedures within kern_objcache.c then to have to pass them explicitly.

why do we have to call the ctor and dtor anyways? why not do if (oc->ctor) oc->ctor(obj); ? or am i missing something important there?


cheers
 simon

--
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \

Attachment: signature.asc
Description: OpenPGP digital signature



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]