Re: cvs commit: src/share/mk bsd.prog.mk

["Simon 'corecode' Schubert" <corecode@xxxxxxxxxxxx>]

Matthew Dillon wrote:
> :corecode    2006/02/13 06:21:25 PST
> :
> :DragonFly src repository
> :
> :  Modified files:
> :    share/mk             bsd.prog.mk 
> :  Log:
> :  Move patch handling out of .if defined(PROG)
> :  
> :  Revision  Changes    Path
> :  1.13      +2 -2      src/share/mk/bsd.prog.mk
> :
> :
> :http://www.dragonflybsd.org/cvsweb/src/share/mk/bsd.prog.mk.diff?r1=1.12&r2=1.13&f=u
>
>     This commit broken buildworld in /usr/src/usr.bin/top.  OBJS is now
>     listing top.o (which is a patched file) twice.

yea, thanks.  i noticed yesterday night but was too tired to fix it.

the problem actually is that top is not correctly using the patch 
framework.  furthermore i don't understand why it is using the patch 
framework at all, because it is sources we got from freebsd.

i see two possibilities:
1) merge patches into the sources we got from freebsd anyways and don't
   use the patch framework
2) move the patches to their correct location in usr.bin/top and rename
   top.X.patch into top.X.no_obj.patch

i'm in favour for 1, except if we update top's sources right away to 
resemble a clear distrib package, but that takes some time.

cheers
  simon

--
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \