DragonFly BSD
DragonFly commits List (threaded) for 2005-08
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/vfs/hpfs hpfs_vnops.c

From: "Simon 'corecode' Schubert" <corecode@xxxxxxxxxxxx>
Date: Sun, 21 Aug 2005 13:40:40 +0200

On 20.08.2005, at 20:37, Joerg Sonnenberger wrote:

joerg 2005/08/20 11:37:21 PDT

DragonFly src repository

  Modified files:
    sys/vfs/hpfs         hpfs_vnops.c
  HPFS != UFS, so use the right constant for directory entries. Check
  explicitly for wraparound or negative offsets, don't depend on type
  limits to do that.
- * As we need to fake up . and .., and the remaining directory structure
- * can't be expressed in one off_t as well, we just increment uio_offset
- * by 1 for each entry.
- *

why did you remove this comment I just put in? I think having explaining comments especially in source that don't get touched every day by the average developer are very helpful and ease understanding the code a big deal. Please put it back.


Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low $$$ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \

Attachment: PGP.sig
Description: This is a digitally signed message part

[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]