Re: cvs commit: src/sys/sys thread.h thread2.h src/sys/kern lwkt_token.c lwkt_thread.c

[Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>]

On Thu, Jul 07, 2005 at 01:28:26PM -0700, Hiten Pandya wrote:
>   KTR tracepoints have been added for marking start and stop of a token's
>   contention.  New field tr_flags added to struct lwkt_tokref.  By adding
>   tracepoints in lwkt_chktokens(9),  it gives us interesting data on MP
>   machines when it indirectly sends a passive IPI to the remote CPU for
>   gaining ownership of a token.  It would be interesting to see KTR dumps
>   for a 4-CPU or an 8-CPU system.

While I agree that this is a good thing to have, I don't think
putting it under INVARIANTS is appropiate. It doesn't match the
exceptations assiociated with it. I also think that we will add
similiar measuring instruments to other parts of the tree soon,
so what about adding a new global option for that?

Joerg