DragonFly BSD
DragonFly commits List (threaded) for 2005-07
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/dev/netif/wi if_wi.c


From: Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>
Date: Mon, 4 Jul 2005 09:12:34 +0200
Mail-followup-to: commits@crater.dragonflybsd.org

On Mon, Jul 04, 2005 at 02:16:55PM +0800, Sepherosa Ziehau wrote:
> if we have setup intr in the last step of  wi_attach(), then why not
> 
> in wi_detach():
> ...
> bus_teardown_intr();
> WL_UNLOCK();
> wi_free();
> ...
> 
> in wi_free():
> remove bus_teardown_intr() related code.  since with the above
> changes, when wi_free() is called, intr is not setup (including setup
> failure) or has been torn down

That would definitely work, but I wanted to keep the change small for now.
There are much bigger problems to worry about in this driver.

Joerg



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]