DragonFly commits List (threaded) for 2005-06
Re: cvs commit: src/contrib/bzip2-1.0 README.DELETED sample1.bz2 sample1.ref sample2.bz2 sample2.ref sample3.bz2 sample3.ref words1 words3
On Thu, Jun 30, 2005 at 07:10:59PM +0200, Simon 'corecode' Schubert wrote:
> Lately Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxxxxxxxx> said:
> > joerg 2005/06/30 10:05:00 PDT
> > DragonFly src repository
> > Modified files:
> > contrib/bzip2-1.0 README.DELETED
> > Removed files:
> > contrib/bzip2-1.0 sample1.bz2 sample1.ref sample2.bz2
> > sample2.ref sample3.bz2 sample3.ref
> > words1 words3
> > Log:
> > don't include regression tests, we don't use them anyway. more than enough
> > samples in the wild.
> yes, we do use them. see usr.bin/bzip2/Makefile, target "test". And I'd
> like them to stay, there is a reason for integrated regression tests.
> Please back this change out.
My fault. We have regressions tests, yes. But quite frankly, we can do that
without including this files. The "regression" test doesn't only test for
working compression / decompression, but for an identical result. That's
IMO not a good thing when you consider that a different implementation
of libbz2 (e.g. tuned) can create different output. For example, 7zip
advertises up to 3% better compression.