DragonFly BSD
DragonFly commits List (threaded) for 2005-05
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/i386/i386 nexus.c src/sys/i386/include atomic.h src/sys/kern kern_poll.c lwkt_serialize.c src/sys/net if.c if_var.h rtsock.c src/sbin/ifconfig ifconfig.c src/sys/dev/netif/dc if_dc.c src/sys/dev/netif/em if_em.c if_em.h ...

From: Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>
Date: Fri, 27 May 2005 16:51:40 +0200
Mail-followup-to: commits@crater.dragonflybsd.org

On Fri, May 27, 2005 at 02:20:47PM +0100, Hiten Pandya wrote:
> 	First, you are inconsistently setting DEVICE_POLLING in some
> 	places, when it should be IFCAP_POLLING.

Yeah, so that too.

> 	Secondly, why not just check if ifp->if_poll is set and then
> 	mark the interface has having polling capability in the generic
> 	interface code? i.e. in net/if.c somewhere ?

I was about the change that :) I'm even thinking about removing the
kern.polling.enable and mark interfaces by default as not IFCAP_POLLING.
The code would automatically enable it, when we have an interface wanting


[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]