DragonFly BSD
DragonFly commits List (threaded) for 2005-05
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/boot/i386/boot2 boot2.c src/sys/boot/i386/libi386 comconsole.c src/sys/boot/i386/loader main.c


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 4 May 2005 12:53:08 -0700 (PDT)

:Why is the conditional "cmd[0] == 0" just before the second call
:to parse() needed? It totally disables the boot.config feature,
:and hitting Enter key ends up with a beep and won't let you use
:the default configuration shown on the console.
:...
:
:    for (;;) {
:	printf("\nDragonFly boot\n"
:	       "%u:%s(%u,%c)%s: ",
:	       dsk.drive & DRV_MASK, dev_nm[dsk.type], dsk.unit,
:	       'a' + dsk.part, kname);
:	if (!autoboot || keyhit(5*SECOND))
:	    getstr();
:	else
:	    putchar('\n');
:	autoboot = 0;
:	if (cmd[0] == 0 || parse())		/* <-- HERE */
:	    putchar('\a');
:	else
:	    load();
:    }
:}

    Hmm.  I can't think of a reason.  Try removing it and see what
    happens.  And I've noticed that issue too, it will be nice to
    see it fixed.

					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]