DragonFly BSD
DragonFly commits List (threaded) for 2004-10
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/usr.bin/objformat

From: "Simon 'corecode' Schubert" <corecode@xxxxxxxxxxxx>
Date: Tue, 26 Oct 2004 22:52:14 +0200

On 26.10.2004, at 21:05, Matthew Dillon wrote:
:If you want to ensure you have a gcc 3.4 only system, CCVER is a bit
:difficult. E.g. it doesn't work if the environmental variable gets
:lost and so on. Allowing to change the default of objformat makes it
:friendlier at least for those trying to tweak the bugs out of a 3.4
:only world.
:> At a minimum I would recommend that the BINUTILSVER_DEFAULT be removed.
:> That can create massive confusion. I would prefer objformat to select
:> the binutils to use based on the CC version.
:Actually it seems to be a nop anyway. I want to keep BINUTILSVER_DEFAULT,
:but it will have the meaning of the fallthough entry if CCVER points to
:an unknown compiler. For the other cases, I'll defines to centralise changes
:of binutils versions.
In anycase, I think this is ok if you rename the make.conf variable to
make it clear that it is a compile-time variable for objformat and not
a dynamic variable. Maybe something like OBJFORMAT_BUILD_CCVER_DEFAULT
instead of CCVER_DEFAULT. Something that cannot be mistaken :-)

I advocate for using varsym variables for this purpose.


\ /
 \     ASCII Ribbon Campaign
/ \  Against HTML Mail and News

Attachment: PGP.sig
Description: This is a digitally signed message part

[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]