Re: cvs commit: src/sys/sys bus_private.h

[Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>]

   This is fine, though in general it should be noted that it is better
   for the kernel header files to use machine types from machine/stdint.h
   so as not to create unnessary namespace pollution by requiring that
   <sys/types> be included.  Header files would be able
   to safely conditionally #include <machine/stdint.h> and friends without
   polluting the namespace and thus become more self-contained.
   (generally speaking, only sys header files and source should
   directly include machine/ header files like that).

   A good example of this would be a program that uses old-style varargs.h,
   and we have several.  We would not want any of our header files which
   use varargs internally to include <stdarg.h> because it would conflict
   with programs using the old-style varargs.h, which is why they all use
   machine/stdarg.h.

					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>

:joerg       2004/03/01 03:50:59 PST
:
:DragonFly src repository
:
:  Modified files:
:    sys/sys              bus_private.h 
:  Log:
:  Adjust indentation, use uint32_t and line up comments.
:  
:  Revision  Changes    Path
:  1.4       +62 -62    src/sys/sys/bus_private.h
:
:
:http://www.dragonflybsd.org/cvsweb/src/sys/sys/bus_private.h.diff?r1=1.3&r2=1.4&f=h