DragonFly commits List (threaded) for 2003-09
Re: cvs commit: src/sys/conf Makefile.i386 files files.i386 options src/sys/contrib/dev/acpica acapps.h acconfig.h acdebug.h acdisasm.h acdispat.h acefi.h acenv.h acevents.h acexcep.h acfreebsd.h acgcc.h acglobal.h achware.h acinterp.h aclocal.h ...
David Rhodus wrote:
drhodus 2003/09/23 20:32:17 PDT
* OSPM ACPI driver. Note that this driver does not include
support for PCI interrupt routing or enumeration of ISA bridges or
Host to PCI bridges. While functional on some machines, this driver
should be considered experimental and should be tested prior to being
deployed in a production environment.
Hmm, not that I want to make a big deal out of it, but didn't
we all agree that the patchset should first be put on the
DF website before committing it? This is quite a considerable
amount of files, and it will be hard to keep track of a big
beast like ACPI...
Once the other DEV restructuring parts come in, we will be
having a hard time David... I don't know how a backout for
such a large commit can be done, but I wonder what Matt has
to say about this...
We shouldn't import things from other projects if:
a) They are huge, and they are constantly being updated
b) The code was JUST backported to a -STABLE branch
c) It requires almost constant attention
d) It is based on a framework that is going to change
heavily in the near future...
This is my opinion on this commit, others may differ.