Re: pppoe connection problems

[YONETANI Tomokazu <qhwt+dfly@xxxxxxxxxx>]

On Tue, Jun 06, 2006 at 08:26:06PM +0900, YONETANI Tomokazu wrote:
> On Mon, Jun 05, 2006 at 01:31:04PM -0700, Matthew Dillon wrote:
> > :http://leaf.dragonflybsd.org/mailarchive/commits/2006-05/msg00113.html
> > :netmsg embeded in the mbuf, hhhmmm... no idea
> > :
> > :unfortunately most of them are quite "big", touching many files etc; so
> > :any help debugging this further appreciated
> > 
> >     It's probably this one, I'll take a look at it as soon as I get the
> >     scheduler bug fixed.
> 
> Ok, here's a bandaid until Matt makes his mind on how to fix this issue
> (other "do not reply!" comments may need similar bandaids depending
>  on your network configuration):
> 
> Index: ng_base.c

Oops, copy&paste error...

--- sys/netgraph/netgraph/ng_base.c	Sat Jun 03 08:06:31 2006 +0000
+++ sys/netgraph/netgraph/ng_base.c	Tue Jun 06 22:55:38 2006 +0900
@@ -2087,7 +2087,9 @@ ngintr(struct netmsg *pmsg)
 		}
 	}
 out:
-	/* pmsg was embedded in the mbuf, do not reply! */
+	/* netgraph code may receive non embedded-in-mbuf netmsg's */
+	if (&pmsg->nm_lmsg != &m->m_hdr.mh_netmsg.nm_lmsg)
+		lwkt_replymsg(&pmsg->nm_lmsg, 0);
 	return(EASYNC);
 }