DragonFly BSD
DragonFly bugs List (threaded) for 2005-01
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: Routing bugs: zebra/quagga are unusable => ifconfig bug


From: Adrian Bocaniciu <a.bocaniciu@xxxxxxxxxxxx>
Date: Wed, 05 Jan 2005 14:32:05 +0000
Cc: Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>

The ifconfig bug described in my initial message is caused by the line 532 of sbin.ifconfig/ifconfig.c, after calling clone_create():

goto end;

in FreeBSD that line was:

exit(0);


The goto is incorrect because at the end there is no information about the fact that a new interface has been created. That information could be saved in a variable, e.g. by incrementing "foundit", but it is much more simple to revert to the FreeBSD line.



One way or the other, this must be corrected, especially for the cases when ifconfig is used in scripts, where the returned error code will lead to wrong decisions.



Best regards !




[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]