DragonFly BSD
DragonFly bugs List (threaded) for 2004-12
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: NFS serving off NTFS panic


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 23 Dec 2004 20:49:42 -0800 (PST)

:Patch helped slightly. It no longer panics on nfsd start. It now panics 
:on remote mounting of the exported volume. The mount finishes fine, but 
:when you try to do anything and notice the client goes into deep space, 
:it's a sign the host died.
:
:Backtrace this time (doesn't appear too different, but I have untrained 
:eyes; my best debugging efforts involve printf):

    Ok.  I'm not sure if this is the correct fix, but I think it will
    work.  Please try it out.

					-Matt

Index: nfs_serv.c
===================================================================
RCS file: /cvs/src/sys/vfs/nfs/nfs_serv.c,v
retrieving revision 1.21
diff -u -r1.21 nfs_serv.c
--- nfs_serv.c	20 Dec 2004 18:37:59 -0000	1.21
+++ nfs_serv.c	24 Dec 2004 04:48:43 -0000
@@ -3285,8 +3285,10 @@
 		error = 0;
 		goto nfsmout;
 	}
-	vput(nvp);
-	nvp = NULL;
+	if (nvp) {
+		vput(nvp);
+		nvp = NULL;
+	}
 	    
 	dirlen = len = NFSX_V3POSTOPATTR + NFSX_V3COOKIEVERF + 2 * NFSX_UNSIGNED;
 	nfsm_reply(cnt);



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]