DragonFly bugs List (threaded) for 2004-06
Re: Mozilla behaving strangely today
Matthew Dillon wrote:
:Hiten Pandya wrote:
:> Could you try backing out my change to src/lib/libc/stdio/fclose.c,
:> and see if that helps the situation?
:Why, yes, it does indeed fix the problem, thanks! :o)
:I only backed out to version 1.4, though 1.3 was only about
:eight minutes older than 1.4.
Wow, I would never have thought that changing the location of
the FUNLOCKFILE() call would have had that effect, but now looking
at _funlockfile() in libc_r/uthread/uthread_file.c ... it's obvious.
That's really terrible programming on the original author's part, FILE
structure locks should not be dependant on the contents of the fp. The
whole thing is conditionalized on the file descriptor being non-negative.
Hiten, when you back out that fclose change put a big fat comment in
there describing why FUNLOCKFILE() can't be moved.
Thanks to 'walt' and others for telling us before release.
Oops, I committed before reading this message; will add the
comment for sure. Stupid, thats what it is... :-)