DragonFly BSD
DragonFly bugs List (threaded) for 2004-06
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: Mozilla behaving strangely today

To: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
From: Hiten Pandya <hmp@xxxxxxxxxxxxx>
Date: Wed, 09 Jun 2004 20:31:19 +0100

Matthew Dillon wrote:
:Hiten Pandya wrote:
:> Could you try backing out my change to src/lib/libc/stdio/fclose.c,
:> and see if that helps the situation?
:Why, yes, it does indeed fix the problem, thanks!  :o)
:I only backed out to version 1.4, though 1.3 was only about
:eight minutes older than 1.4.
:Good guess!

    Wow, I would never have thought that changing the location of
    the FUNLOCKFILE() call would have had that effect, but now looking
    at _funlockfile() in libc_r/uthread/uthread_file.c ... it's obvious.
    That's really terrible programming on the original author's part, FILE
    structure locks should not be dependant on the contents of the fp.  The
    whole thing is conditionalized on the file descriptor being non-negative.

    Hiten, when you back out that fclose change put a big fat comment in
    there describing why FUNLOCKFILE() can't be moved.

Oops, I committed before reading this message; will add the comment for sure. Stupid, thats what it is... :-)

Thanks to 'walt' and others for telling us before release.


[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]